search

nightscout / Trio

MIT License
64 stars 259 forks source link

Fix Calibration issue first start #142

Closed avouspierre closed 3 months ago

avouspierre commented 3 months ago

Fix the issue #92 by removing the sync process queue (seems not useful).

bjornoleh commented 3 months ago

@kylmcw , would you have a chance to test calibrations from this branch? https://github.com/avouspierre/Open-iAPS/tree/fix-Calibration-92

Ask @avouspierre for repository access if needed

bjornoleh commented 3 months ago

I could not reproduce the issue again before applying this fix (tried both fresh build and on top of previous build). But I am also not seeing any issues with running fix-Calibration-92 briefly, and I will take your word for this change.

marionbarker commented 3 months ago

I was not able to reproduce the crash in my earlier tests (after @bjornoleh reported his crash).

avouspierre commented 3 months ago

I think this issue occurs only with simulator CGM.

bjornoleh commented 3 months ago

I did try with simulator without being able to reproduce the issue (with or without this fix). I also briefly tested the calibration function for Libre Demo, and it seems to work as expected too. I suggest we merge this PR.

kylmcw commented 3 months ago

@bjornoleh sorry i've been MIA with a horrific stomach bug - does this still need tested? I can see the suggestion to merge so just checking.

marionbarker commented 3 months ago

My crashes have all been with me returning to dev branch. Creating a new feature branch. Modifying code in preparation for generating a PR. First build with Xcode crashes, second and subsequent builds are fine.

And it's not every time I return to dev and switch to create a new branch - but it has happened to me 2 times today.