search

nightscout / Trio

MIT License
49 stars 154 forks source link

fix resistanceLowersTarget #155

Closed MikePlante1 closed 2 months ago

MikePlante1 commented 2 months ago

Reproduced the error with current dev where target does not change even when resistance is detected and Resistance Lowers Target is toggled on.

After applying this PR, target was lowered as expected.

⚠️ WARNING: This fix will reset preferences again.

Addresses https://github.com/nightscout/Open-iAPS/issues/152

MikePlante1 commented 2 months ago

DynamicISF is off, no temp targets or profile overrides are being used:

settings

Test before applying this PR:

prePR2 prePR1

Test after applying this PR:

postPR2 postPR2
bjornoleh commented 2 months ago

@mountrcg , does this look ok?

mountrcg commented 2 months ago

Sry screwed up the reviews here.