search

nightscout / Trio

MIT License
49 stars 154 forks source link

Update Defaults (high, rulerMarks, maxCarbs, sensitivityRaisesTarget) #156

Closed MikePlante1 closed 2 months ago

MikePlante1 commented 2 months ago

high (for stats & main chart line): 145 -> 180 rulerMarks (the high/low lines on the main chart): false -> true maxCarbs: 1000 -> 250 sensitivityRaisesTarget: true -> false

bjornoleh commented 2 months ago

Looks good. Should we also take a Quick Look at the defaults inPreferences (OpenAPS settings)? I believe there are some things that could be off. Specifically, “Sensitivity Raises Target” currently defaults to ON. I suggest change this to OFF.

Good to get this done now that setting are being reset by similar changes.

MikePlante1 commented 2 months ago

Specifically, “Sensitivity Raises Target” currently defaults to ON. I suggest change this to OFF.

Looks like OpenAPS defaults that to ON as well, though: https://github.com/openaps/oref0/blob/88cf032aa74ff25f69464a7d9cd601ee3940c0b3/lib/profile/index.js#L24

MikePlante1 commented 2 months ago

Looks like OpenAPS also defaults UAM to ON, though. 🤔

bjornoleh commented 2 months ago

Specifically, “Sensitivity Raises Target” currently defaults to ON. I suggest change this to OFF.

Looks like OpenAPS defaults that to ON as well, though: https://github.com/openaps/oref0/blob/88cf032aa74ff25f69464a7d9cd601ee3940c0b3/lib/profile/index.js#L24

Thanks for checking. What’s the verdict on that setting in our app? How does it fit if enabling dynamic ISF? My impression from looking at others discussing it is that it causes more problems than it solves, but I have always turned it off, so can’t really tell.

MikePlante1 commented 2 months ago

Adding for transparency that this was discussed more extensively on Discord.