nightscout / Trio

MIT License
49 stars 154 forks source link

Override refactoring and additional functionnalities #158

Closed avouspierre closed 2 months ago

avouspierre commented 2 months ago

The PR includes a large refactoring of the swift part of override/profile functions :

  • Use of swiftInject (dependency injection) with the use of protocol class in the code
  • Use of MVP principes, in particular not use of direct coredata in view class
  • Use of a proxy model class between coredata and the app to manage changes of core data
  • Use of the pattern of observe to refresh data/view/uploads

This PR do NOT change the logic with oref and the interface of override informations in oref. This PR do NOT require a update of trio-oref code.

TODO : Changes the shortcuts after merging with PR #144 and add watch for overrides.

override display override in NS
Simulator Screenshot - iPhone 15 - 2024-05-07 at 21 43 34 CleanShot 2024-05-07 at 21 44 16
marionbarker commented 2 months ago

This seems to be missing this PR merged to dev. Use APP_DISPLAY_NAME - do not hard code. https://github.com/nightscout/Trio/pull/151- MOn May 7, 2024, at 9:02 PM, MikePlante1 @.***> wrote: @MikePlante1 commented on this pull request.

In FreeAPS.xcodeproj/project.pbxproj:

@@ -3230,7 +3250,7 @@ GENERATE_INFOPLIST_FILE = YES; IBSC_MODULE = FreeAPSWatch_WatchKit_Extension; INFOPLIST_FILE = FreeAPSWatch/Info.plist;

  • INFOPLIST_KEY_CFBundleDisplayName = Open-iAPS;
  • INFOPLIST_KEY_CFBundleDisplayName = "Open-iAPS";

*Trio

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because your review was requested.Message ID: @.***>

avouspierre commented 2 months ago

replaced by #159