Closed avouspierre closed 2 months ago
I created a new PR to be able to merge with the current dev version. Unable to do with the previous PR.
Have not thoroughly reviewed the PR, but just on a brief skim:
OverrideProfil
needs an e so it's Profile
guard
/ if let…
these optionals, but simply opting for nil
results hides error until they may show up in a very different layer of the app. A concise error log would be more helpful imho.Please pull in latest dev
so this can be checked out and tested on top of latest dev
:)
Overall, great work.
Please pull in latest
dev
so this can be checked out and tested on top of latestdev
:)
Thanks @dnzxy. I updated the branch with the last version of the dev, did few tests in simulator but not updated with your proposals. Will do later in the week-end.
The PR includes a large refactoring of the swift part of override/profile functions :
This PR do NOT change the logic with oref and the interface of override informations in oref. This PR do NOT require a update of trio-oref code.
TODO : Changes the shortcuts after merging with PR #144 and add watch for overrides.