nightscout / Trio

MIT License
49 stars 154 forks source link

Restore identifier #164

Closed MikePlante1 closed 2 months ago

MikePlante1 commented 2 months ago

This reverts a few lines from commit 08e6a801a21d8d742f9cccebb5102913df00a68f.

@avouspierre mentioned it wasn't used now, so it was okay to delete, and it built and worked fine with an Xcode build, but it prevented me from building via GitHub: failed run

After applying this PR, it built successfully: successful run

marionbarker commented 2 months ago

Repeating comment in both PR #163 and PR #164 because both are required.

Success for Browser Build with PR 163 + 164 added to dev (including the merged PR 165).

First build failed because I inadvertently modified swiftpm/Package.resolved Once I reverted that change, it was successful.

avouspierre commented 2 months ago

Strange to I understand the difference 😫