Open kylmcw opened 6 months ago
@avouspierre
Very good point with a difficulty to resolve quickly, without changing the logic of the alarm notification.
The alarm notifications are integrated in Libre package plugin with his own "BG" (the value that it will send to Trio core app). And, the correction of BG with calibration value is done after (by trio app). Probably the issue was here (and always is) in iAPS.
Different scenarios of solutions :
hey 👋 - silence for 30 days 🤐 ... anybody? triage is required!
closed 📴 because silencio 🤫 since an additional 14 days after staleness 📠
Tagging @dabear in case this is not on your radar already.
I am not certain I understand this problem. Libretransmitter has its own experimental calibration feature. Libretransmitters alarm feature does work on top of this calibration. allowsEditingFactoryCalibrationData must be set to true though (it's experimental so not something that should be set to true by default).
If trio implements calibration on top of the value returned by Libretransmitter, Libretransmitter would not know about or use that for alarming. If Trio modifies the glucose values returned, it should also be responsible for sending out any alarms rather than letting Libretransmitter do it
Ok, thanks for the info, I believe Trio has its own calibration on top. Maybe the Libre alarms should be disabled when libretransmitter is used in Trio? And replaced with Trio specific alarms perhaps?
Tagging @kskandis , whom I believe is working on alarms/alerts in Trio?
(For Loop I did have long conversations with Pete about this; basically I wanted Loop to provide the alarms, while Pete insisted that each cgmManager implements its own alarm handling)
If needed, I can add a feature flag to libretransmitter to programatically disable alarms, both from ui and the alarm handling code itself
I believe Loop now also supports a cheaper Dexcom targeted at T2 without alarms in its accompanying app. Hence this discussion will probably reemerge. Adding the alarms at the CGM manager level sounds a little like duplicating of work across CGM managers.
Pete did not accept the pull request for Stelo support into Loop yet. He is wearing one himself but was concerned about alarms.
Ok, thanks for the info, I believe Trio has its own calibration on top. Maybe the Libre alarms should be disabled when libretransmitter is used in Trio? And replaced with Trio specific alarms perhaps?
Tagging @kskandis , whom I believe is working on alarms/alerts in Trio?
Yes, agree, Libre plugin has its own set of notifications that are enabled in the plugin by the user in NotificationsSettingsView, saved to UserDefaults, and based on those settings, Libre will send APN in NotificationsHelper.
This is similar to what Trio does. Trio, of course, already has High/Low BG notifications if the user enables them in Settings - Notifications - Glucose Notifications. The other Libre notifications are Libre specific which currently Trio does not process. Looking at the code, Libre does send the LibreError which Trio's PluginSource cgmDelegate should be able to process. I see there is a // TODO comment there.
Describe the bug Using Libre, when a high or low notification is sounded, the app appears to be using non calibrated data to trigger the alarm, despite being lower (in this case) than the alarm trigger point.
To Reproduce Steps to reproduce the behavior:
Expected behavior A clear and concise description of what you expected to happen. High alert only applies to calibrated values.
Screenshots If applicable, add screenshots to help explain your problem.
Smartphone (please complete the following information): iPhone 15 Pro
Setup Information (please complete the following information):
Additional context Add any other context about the problem here.