nightscout / Trio

MIT License
49 stars 154 forks source link

Libre Alarms Using Non Calibrated Data #167

Open kylmcw opened 2 months ago

kylmcw commented 2 months ago

Describe the bug Using Libre, when a high or low notification is sounded, the app appears to be using non calibrated data to trigger the alarm, despite being lower (in this case) than the alarm trigger point.

To Reproduce Steps to reproduce the behavior:

  1. Calibrate Libre sensor to a value below default
  2. Observe when default value in GCM settings exceeds threshold, but calibrated value is below.
  3. Observe high alert

Expected behavior A clear and concise description of what you expected to happen. High alert only applies to calibrated values.

Screenshots If applicable, add screenshots to help explain your problem.

image image image Smartphone (please complete the following information): iPhone 15 Pro

Setup Information (please complete the following information):

Additional context Add any other context about the problem here.

kylmcw commented 2 months ago

@avouspierre

avouspierre commented 2 months ago

Very good point with a difficulty to resolve quickly, without changing the logic of the alarm notification.

The alarm notifications are integrated in Libre package plugin with his own "BG" (the value that it will send to Trio core app). And, the correction of BG with calibration value is done after (by trio app). Probably the issue was here (and always is) in iAPS.

Different scenarios of solutions :

github-actions[bot] commented 1 week ago

hey 👋 - silence for 30 days 🤐 ... anybody? triage is required!