search

nightscout / Trio

MIT License
49 stars 154 forks source link

fix importing settings from Nightscout #170

Closed MikePlante1 closed 2 months ago

MikePlante1 commented 2 months ago

Before this PR, two settings were not imported from Nightscout correctly for me. My 95 mg/dL target glucose got imported as 72 mg/dL (the lowest allowed) My 58mg/dL ISF got imported as 9 mg/dL

After applying this PR and building to a fresh now simulator, my settings were imported correctly.

I then reset the simulator and installed this PR again to test with somebody else's Nightscout which uses mmol/L and confirmed target glucose and ISF did get imported correctly as well.

pheltzel commented 2 months ago

I believe Trio v0.1.0 is still doing this -- this happened to me too, today. My 2 segments of ISF (55 and 60) were imported as 9. And my target was set to 72.

bjornoleh commented 2 months ago

I believe Trio v0.1.0 is still doing this -- this happened to me too, today. My 2 segments of ISF (55 and 60) were imported as 9. And my target was set to 72.

Yes, this PR has not yet been merged, so current dev still has this issue.

pheltzel commented 2 months ago

I know this was already merged, but I tested this morning -- the error occurred when importing, using mg/dl. I applied the fix, reimported from NS and then settings were imported correctly. Thanks!