nightscout / Trio

MIT License
49 stars 154 forks source link

Override refactoring and additional functionnalities #178

Closed avouspierre closed 1 month ago

avouspierre commented 2 months ago

The PR includes a large refactoring of the swift part of override/profile functions :

  • Use of swiftInject (dependency injection) with the use of protocol class in the code
  • Use of MVP principes, in particular not use of direct coredata in view class
  • Use of a proxy model class between coredata and the app to manage changes of core data
  • Use of the pattern of observe to refresh data/view/uploads

This PR do NOT change the logic with oref and the interface of override informations in oref. This PR do NOT require a update of trio-oref code.

TODO : Changes the shortcuts after merging with PR #144 and add watch for overrides.

override display override in NS
Simulator Screenshot - iPhone 15 - 2024-05-07 at 21 43 34 CleanShot 2024-05-07 at 21 44 16
sonarcloud[bot] commented 2 months ago

Quality Gate Failed Quality Gate failed

Failed conditions
3 Security Hotspots
7.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

avouspierre commented 1 month ago

replaced by #219