search

nightscout / Trio

MIT License
49 stars 154 forks source link

Update README.md: Create ConfigOverride.xcconfig by command line #180

Closed bjornoleh closed 2 months ago

marionbarker commented 2 months ago

I recommend adding the BuildTrio.sh instructions below the line that says there is a script available.

Copy the code embedded here into the Trio README:

https://github.com/loopandlearn/lnl-scripts/tree/main?tab=readme-ov-file#scripts-for-the-trio-app

Code inspection OK of what you added looks good but I can’t test it right now.

bjornoleh commented 2 months ago

We can fit that in here if someone has a chance to push it now, otherwise merge as is.

MikePlante1 commented 2 months ago

We can fit that in here if someone has a chance to push it now, otherwise merge as is.

Thoughts on this?

CLI readme
bjornoleh commented 2 months ago

We can fit that in here if someone has a chance to push it now, otherwise merge as is.

Thoughts on this?

Looks great!

marionbarker commented 2 months ago

I reviewed the entire README file after the last commit/ Please add the missing links that are now known.

Look for TODO:

Tests:

MikePlante1 commented 2 months ago

I reviewed the entire README file after the last commit/ Please add the missing links that are now known.

Look for TODO:

  • There are 3 of them
  • I know at least one of those is now known.

I added a link for Docs (and links to FAX and Oref0), but should probably wait to add the website (diy-trio.org) and the Crowdin (until @t1dude says it's ready for contributions)

MikePlante1 commented 2 months ago

git clone --branch=<branch> --recurse-submodules https://github.com/nightscout/Trio.git && cd Trio

Thanks for the suggestion.

2-line in zsh: success 2-line in bash: fail 1-line in zsh: success 1-line in bash: success

I'll commit that now with you as the author