search

nightscout / Trio

Trio - an automated insulin delivery system for iOS based on the OpenAPS algorithm with adaptations.
https://docs.diy-trio.org/en/latest/
MIT License
81 stars 423 forks source link

ISF value in enacted pop-up "pill" shows only final ISF #186

Closed MRMProd closed 3 months ago

MRMProd commented 4 months ago

Describe the bug In the pop-up pill ISF value shows final ISF two times, "ISF: 2.2 > 2.2"

To Reproduce Steps to reproduce the behavior:

  1. Enable an Override with adjustment to ISF
  2. Click on loop symbol to bring up the pill..'
  3. See error

Expected behavior correct should be in my example "ISF:3.0 > 2.2"

Screenshots IMG_54F0D4D19230-1

bjornoleh commented 4 months ago

I think this is feature and not bug. The ISF value is adjusted according to the override, but dynamic ISF or autosens is still able to adjust ISF on top of this, which would show up as the ISF value at the right hand side of the arrow.

I think this issue can be closed as not being a bug?

MRMProd commented 4 months ago

Removed this post since update to latest solved some issues. But when enabling Dynamic CR or ISF it is not showing the dynamic adjustments in the pill? That must still be a bug not showing final ISF/CR? Final ISF/CR are not shown in log file either? Little confused with "EnableDynamicISF" called "useNewFormula" now

dnzxy commented 4 months ago

@MRMProd could you please provide a more verbose list of steps of what exactly you are doing and what outcome you see but that isn’t along the lines of what you would expect to be true.

I must admit I am having a bit of trouble to follow what you are trying to see with which settings under which context where - log and or loop status hud 🤔

MRMProd commented 4 months ago

If enabling dynamic ISF and/or dynamic CR nothing shows in the pill? IMG_7731 IMG_7733 the scheduled ISF are 3

MRMProd commented 4 months ago

Here are an old 2.3.3 with Dynamic ISF and CR enabled 415976157_10231599999165778_1142577532351990099_n 2

dnzxy commented 4 months ago

Have there been >1 loop cycles between you enabling it and looking at the hud? Sorry for asking seemingly weird question, just trying to get all details of what you do and what the expected outcome is.

MikePlante1 commented 4 months ago

@MRMProd Your 2.3.3 screenshot shows that DynamicISF is being used with Sigmoid off (all the purple blocks) and that Autosens has been calculated by DynamicISF to be 0.7.

Your Trio screenshot however, does not show DynamicISF being used at all, and Autosens is set to 1, therefore both X and Y in X->Y are the same.

Like @dnzxy mentioned, the HUD only changes after a loop cycle is ran, so toggling on Dynamic ISF (and CR) won't affect the HUD until the next loop cycle runs.

But also, has Trio been running for 21+ hours with a real pump and cgm attached to it? Because DynamicISF requires a minimum of 21 hours of insulin data to run.

MikePlante1 commented 4 months ago

Little confused with "EnableDynamicISF" called "useNewFormula" now

I agree that name is not great, but that's what it was called in iAPS 2.3.3, and looks like it's still called that in the latest iAPS 4.2.0

MRMProd commented 4 months ago

Everything seems to work now, you can close this "bug". Most of the issue was 21+ hours making the display not showing correctly. One thing I can add to enhancement is changing the name in the pill from Autosense Ratio to Dynamic Ratio when dynamic is used. This is confusing for new users when they think it is autosense but in reality is dynamic ratio (when dynamic is used). I did get Jon to change that in the new version just to clarify for new users. Sorry for taking up time from you guys but is was really strange before 21 hrs + used.