nightscout / Trio

Trio - an automated insulin delivery system for iOS based on the OpenAPS algorithm with adaptations.
https://docs.diy-trio.org/en/latest/
MIT License
81 stars 423 forks source link

EmaLink doesn't appear to be polled in intervals for battery alarm #188

Open LiroyvH opened 4 months ago

LiroyvH commented 4 months ago

There's an option to have the app alert you when the battery of your EmaLink goes below a user adjustable threshold. (Eg: I have it set to < 30% = alarm.)

However, the app never seems to query the EmaLink (for that variable) unless you go to Pump and tap your EmaLink to view status and reveal the settings. It will only at that moment ask for the battery level, show it and trigger the notification/alarm - at which point it's a bit late.

It'd be nice if the app queries the EmaLink battery once every x hours. Maybe every 3 hours or so? Note: had the same issue in the previous iteration of the app, where it was mentioned that it did work fine for OrangeLink.

Medtronic 754 + EmaLink, Trio Dev, iOS 17.5.

Sjoerd-Bo3 commented 3 months ago

hey 👋 - silence for 30 days 🤐 ... anybody? triage is required!

github-actions[bot] commented 2 months ago

closed 📴 because silencio 🤫 since an additional 14 days after staleness 📠

LiroyvH commented 2 months ago

Not sure it's very handy to auto-close bug reports just because they haven't gotten attention yet, auto-discarding something is probably not the best way forward to eventually work towards an app of which the features are working as expected in a stable manner. I see multiple issues including more severe bugs being moved out now. (This one is mostly just annoying as you cannot rely on the app to warn you about the battery state of an important part of the setup, but not directly dangerous.)

bjornoleh commented 2 months ago

Not sure it's very handy to auto-close bug reports just because they haven't gotten attention yet, auto-discarding something is probably not the best way forward to eventually work towards an app of which the features are working as expected in a stable manner. I see multiple issues including more severe bugs being moved out now. (This one is mostly just annoying as you cannot rely on the app to warn you about the battery state of an important part of the setup, but not directly dangerous.)

Commenting on an auto-closed issue will bring attention to it, and may get it reopened. So no big deal if stakeholders look out for these stale issue/closed issue alerts.