search

nightscout / Trio

MIT License
46 stars 130 forks source link

LiveActivity.swift: widget URL string "Trio://" #197

Closed bjornoleh closed 1 month ago

bjornoleh commented 1 month ago

Replaces widgetURL(URL(string: "freeaps-x://"))

Related to #136

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

bjornoleh commented 1 month ago

Tapping the Live activity widget was unaffected by the change (app opened before and after). But Trio:// is the correct url for whatever it's used for.

MikePlante1 commented 1 month ago

I concur with bjornoleh. Tested opening the app from both the lockscreen widget and the Dynamic Island both before and after applying this PR on a real phone and it worked as usual. Not really sure what (if anything) it affects.

Should it maybe use APP_URL_SCHEME from Config, though? Just a thought. Hardcoding to Trio seems to be fine, though.

bjornoleh commented 1 month ago

I didn't quickly figure out how to use APP_URL_SCHEME here, so went with the hardcoded way instead. Shone more than good enough for this anyways.

MikePlante1 commented 1 month ago

Actually... I even just deleted that line completely and it still seems to work fine. 🤷 So not sure what it's even for.

MikePlante1 commented 1 month ago

Merging this with several approvals and it seems it could even be deleted.