Closed JeremyStorring closed 4 weeks ago
I agree with the suggestions above. The current grey colour is not very noticeable. The rewording could make it a little clearer too.
I agree a color change here would be helpful. How about just changing the text color to red? After line 92 in BolusRootView:
.foregroundStyle(state.amount <= 0 ? .gray : state.amount > state.maxBolus ? .red : .blue)
I used this wording in #172 because I didn't want to break the translations that already exist for this label, and inserting a variable in the middle of the label splits it into two separate translations.
old: Max Bolus exceeded!
+ U
your suggestion: Max Bolus of
+ U exceeded
or to retain the current units translations: Max Bolus of
+ U
+ exceeded
@MikePlante1 this all looks good to me. I agree with making the text red, and we can use Max Bolus of
+ U
+ exceeded
to retain translations :)
That’s the thing, though… changing it means translations aren’t retained (except units). It is a better wording, and there are already plenty of changes that need to be retranslated, so I’ll put this together for a PR. Maybe I’ll combine it with adding a similar feature for Max Carbs.
Potential solution added in #226
Describe the bug When the user exceeds their max bolus, the formatting of the error is a bit ugly.
To Reproduce Steps to reproduce the behavior:
Expected behavior I believe that the warning should 1) Be more visible, instead of blending in with everything else 2) Have different wording, such as "Max bolus of # U exceeded."
Screenshots![image](https://github.com/nightscout/Trio/assets/37644909/cc814be9-2359-4a9b-8707-3c5e5e94d858)
Smartphone (please complete the following information): iPhone 14 (but not applicable)
Setup Information (please complete the following information):