search

nightscout / Trio

MIT License
46 stars 130 forks source link

Meal settings has incorrect text #213

Open JeremyStorring opened 1 month ago

JeremyStorring commented 1 month ago

Describe the bug When you navigate to meal settings, the settable option refers to "Override with a factor of", while the help text below refers to "Adjustment factor". This is not entirely clear, and the settable option should be changed to "Adjustment Factor"

To Reproduce Steps to reproduce the behavior:

  1. Go to Meal Settings
  2. Look at text for last option and help text

Expected behavior Set "Override..." with "Adjustment Factor" to match help text.

Screenshots image

Smartphone (please complete the following information): iPhone 14

Setup Information (please complete the following information):

bjornoleh commented 1 month ago

This setting is a scaling factor for the FPU result, to enable adjustments of the Warsaw formula output. I think the name “Adjustment factor” is already ”taken” by the one used by dynamic ISF, so perhaps find a better name for this one. Maybe “FPU Factor”?

JeremyStorring commented 1 month ago

That seems reasonable to me, using "FPU Factor" and being consistent should solve the problem!