nightscout / Trio

MIT License
45 stars 125 forks source link

Fix the dexcom share in Trio #282

Closed avouspierre closed 2 weeks ago

avouspierre commented 3 weeks ago

The PR allows to fetch BG of Dexcom share as a CGM as well as to fetch BG of Dexcom share with the Dexcom G6 CGM.

The PR updates the logic of the CGM fetch for all CGM based on Loop submodules (PluginSource).

Test requirements

1. - IOS Simulator - Add Dexcom Share CGM

2. - Iphone 8 - Add G6 CGM

3. - iphone 15 - Add G6 CGM with G6 sensor

Need to be tested with Libre and Dexcom G7. Both implement the fetchIfNeeded function with noData response.

Sjoerd-Bo3 commented 3 weeks ago

Going to test on G7

marionbarker commented 3 weeks ago

Summary

Success - works with phone locked so long as pump has a heartbeat.

Configuration

Testing

bjornoleh commented 2 weeks ago

Should this target alpha instead of dev?

I changed the base branch, which apparently dismisses all previous reviews… Can you resolve the change request? I can’t do that it seems.

bjornoleh commented 2 weeks ago

Merging with three approvals