search

nightscout / Trio

MIT License
45 stars 125 forks source link

use Trio specific names and update instructions in testflight.md #297

Closed marionbarker closed 1 week ago

marionbarker commented 3 weeks ago

Added to this PR - a modification to fastlane/Fastfile to use Trio specific identifier names. (The identifiers themselves are not modified, just the description.)

This PR is in response to Issue #294. With the final version, it also answers issue #174.

bjornoleh commented 3 weeks ago

If you look at my up to date screenshots from yesterday in https://github.com/nightscout/Trio/issues/294, I am unsure if this part is accurate, as I am not seeing the FreeAPS names anywhere in my screenshots? Surely the build targets are still called FreeAPS, but I think it will only bring confusion to mention this here in the context of GH builds and what to look for on the Apple developer portal:

Repeat this step for each NAME with associated IDENTIFIER:

MikePlante1 commented 3 weeks ago

If you look at my up to date screenshots from yesterday in #294, I am unsure if this part is accurate, as I am not seeing the FreeAPS names anywhere in my screenshots? Surely the build targets are still called FreeAPS, but I think it will only bring confusion to mention this here in the context of GH builds and what to look for on the Apple developer portal:

Repeat this step for each NAME with associated IDENTIFIER: FreeAPS: org.nightscout.TEAMID.trio FreeAPS watchkitapp: org.nightscout.TEAMID.trio.watchkitapp * FreeAPS watchkitapp watchkitextension: org.nightscout.TEAMID.trio.watchkitapp.watchkitextension

yours looks like this because you built via Xcode first:

Xcode

Had you never built with Xcode and only built with GitHub, it would have looked like this (except the last one would just say FreeAPS.):

gh
bjornoleh commented 3 weeks ago

Ah, right! I expected differences due to Xcode, just didn’t know exactly what to expect, I thought it was only the XC prefix.

Perhaps we should include instructions to search for Trio if there are many identifiers listed? That really clears it up for most.

marionbarker commented 2 weeks ago

@bjornoleh Are you requesting a modification?

Should I put in a table of what the XC version looks like under NAMES? Or will most people be looking at the docs. Does LiveActivity not get an XC in front of it?

bjornoleh commented 2 weeks ago

@bjornoleh Are you requesting a modification?

Should I put in a table of what the XC version looks like under NAMES? Or will most people be looking at the docs. Does LiveActivity not get an XC in front of it?

A table with the typical names for Xcode vs Fastlane build would be great.

Unsure about LiveActivity, perhaps this was added from a GitHub build because this feature was added later? I would think so.

marionbarker commented 2 weeks ago

Summary

Do some testing prior to building a table for Identifier Names (Descriptions) for Mac-Xcode vs GitHub Actions (Browser Build) method for Trio.

Question:

Do we really need LiveActivity as an identifier for Browser Build?

Tests with Trio alpha, commit 82f2d01.

I deleted all identifiers (except Trio itself) and renamed the Trio description to be XC bundle_id

When I built with Mac-Xcode - these are the only identifiers on my identifiers page - no sign of LiveActivityExtension:

trio-identifiers-from-mac-xcode

I then ran some actions with my fork of Trio-alpha :

trio-identifiers-from-add-identifiers

marionbarker commented 2 weeks ago

I got more information via PM with @dnzxy. I propose a different solution.

proposed-trio-identifiers

Patch for Fastfile: trio-specific-identifiers.patch

marionbarker commented 2 weeks ago

Testing of Proposed Name Change

I created a branch, trio-specific-identifiers, at loopandlearn/Trio with this modification wrt nightscout/Trio alpha:

I am in the process of testing this single Fastfile change after deleting Identifiers, Certificates and Match-Secrets.

marionbarker commented 2 weeks ago

If this modification is added to Trio, then Issue #174 can be closed.

marionbarker commented 2 weeks ago

Test successful with proposed change (see graphic). (Forgot to mark on graphic) Delete all Trio XXX Identifiers

  1. Clear previous certs: delete Match-Secrets and revoke distribution certificates
  2. Successful Action: Add Identifiers
  3. Add Trio App Group to Trio Watch and Trio WatchKit Extension
  4. Successful Action: Create Certificates
  5. Successful Action: Build Trio

Open questions:

trio-specific-identifiers-test

marionbarker commented 1 week ago

This is ready for review.