Closed marionbarker closed 1 week ago
Both G6 and G7 have upload reading enabled for fresh install
I'm not sure why, because I don't notice anything in the diff that would have caused it, but this PR seems to remove the Open Dexcom G6
button from the module.
PR 328 | alpha |
---|---|
@MikePlante1 Thanks for pointing out my mistake. I missed a cherry pick to get trio back in line with loopandlearn dev_rc after creating trio from LoopKit/CGMBLEKit dev branch.
Closing this because it is not as simple as changing the default to be true in the 2 submodules. In fact, iAPS still has the default in CGMBLEKit as false, but there are other changes in iAPS that tie together the Nightscout upload glucose enable flag with the cgm manager upload enable flags.
There were complaints early on that the default setting for the Dexcom CGM modules (in LoopKit) for uploading to remote service was set to false.
That cannot be changed in the LoopKit GitHub username, but the same restriction does not apply in the loopandlearn username.
Modify that default to true for both the CGMBLEKit and G7SensorKit repositories in loopandlearn trio branch.
In addition, the main_rc branch of CGMBLEKit, previously used for Trio (before this PR) had an earlier version of the PR for handling future dates for G6 (which caused issues with the SAGE upload in Loop-dev). The trio branch for loopandlearn CGMBLEKit was updated to use the final form of that PR. See LoopKit: CGMBLEKit PR 191.