add manual glucose value visualization to chart and history

[mountrcg]

Visualize manual Glucose (finger prick) in Chart and history	Chart	History

[dnzxy]

Thank you for tackling this and bringing this small change to Trio.

If I may ask, why the ZStack and to achieve the white outline, and why the white outline? Wouldn’t this also work? Just asking because I seldom see icons have borders on iOS.

[mountrcg]

If I may ask, why the ZStack and to achieve the white outline, and why the white outline? Wouldn’t this also work? Just asking because I seldom see icons have borders on iOS.

fixed!

[MikePlante1]

I just merged this into alpha to test this on a simulator.

I noticed this PR breaks the display when using "Glucose Simulator" for cgm, but it seems that's probably not really so much a problem with this PR as it is that readings from Glucose Simulator use nil for type instead of sgv.

[marionbarker]

Summary

Success using NS as a CGM Switched to CGM simulator and it continued to work - not sure of the configuration that @MikePlante1 referred to.

Test

Began with SE running Trio, alpha branch, commit 3ec6176d, rPi DASH pod and NS as CGM

• added manual glucose reading of 399
  • Manual glucose shows up on main screen as current glucose
  • Manual glucose does not appear in plot
  • Manual glucose appears with -- beside value in history
• applied the patch
  • Manual glucose now shows up in plot
  • Manual glucose appears with red drop beside value in history

[marionbarker]

Realized I had not tested deleting the manual Glucose entry. Returned and test that too. Works as expected.

[MikePlante1]

not sure of the configuration that @MikePlante1 referred to.

I did an Erase all content and settings on this iPhone 15 Pro simulator before building alpha + PR332 to it:

https://github.com/nightscout/Trio/assets/82073483/075a4bae-6e2c-4c52-bf86-00ecc504e9d6

[mountrcg]

Glucose dots for Glucose Simulator and Freestyle Libre Demo are drawn. Only Glucose Simulator dots were not shown due to filtering, Freestyle Libre Demo dots were unaffected (dots before the big glucose jump are Freestyle Libre Demo, after the jump Glucose Simulator)!	Test without filter adjustment	Filter adjusted

[mountrcg]

I just merged this into alpha to test this on a simulator.

I noticed this PR breaks the display when using "Glucose Simulator" for cgm, but it seems that's probably not really so much a problem with this PR as it is that readings from Glucose Simulator use nil for type instead of sgv.

yes the culprit was this PR! Fixed now - see above.

[MikePlante1]

I just retested and confirmed Glucose Simulator display is now fixed. Built it to my live phone as well and everything works great. I did notice some linting from Xcode, but after that's addressed I'll give it a ✅ based on both code review and testing.

[Sjoerd-Bo3]

Got sniped by @dnzxy there 🐌, But also LGTM!