search

nightscout / Trio

Trio - an automated insulin delivery system for iOS based on the OpenAPS algorithm with adaptations.
https://docs.diy-trio.org/en/latest/
MIT License
95 stars 485 forks source link

Config.xcconfig: #include? "../../ConfigOverride.xcconfig" #34

Closed bjornoleh closed 7 months ago

bjornoleh commented 7 months ago

Allow config override file to take action from two directories up, to align with Loop and other DIY projects.

marionbarker commented 7 months ago

Might have hit approve too soon. The reason the ../../ copy of the config override file is placed as the first line in LoopWorkspace is to allow changes made in the root folder to take precedence. Just something to consider. Up to you.

bjornoleh commented 7 months ago

Might have hit approve too soon. The reason the ../../ copy of the config override file is placed as the first line in LoopWorkspace is to allow changes made in the root folder to take precedence. Just something to consider. Up to you.

Yes, I think the last commit makes this PR consistent with that behaviour?

marionbarker commented 7 months ago

If you are waiting for an answer. This is fine to merge. I was overthinking this.