nightscout / Trio

Trio - an automated insulin delivery system for iOS based on the OpenAPS algorithm with adaptations.
https://docs.diy-trio.org/en/latest/
MIT License
98 stars 518 forks source link

Insulin Peak Time: confusing / wrong help text, may affect oref algorithm #347

Open DreyCon-Raphael opened 4 months ago

DreyCon-Raphael commented 4 months ago

Describe the bug

*OpenAPS settings pull information of which insulin curve type to select from the set insulin type of the configured pump. In my case it is Dash with Fiasp. While making some adjustments / finetuning on the OpenAPS settings I discovered this help text: image This made me selecting "rapid-acting" Insulin curve manually as it states: "Oref assumes for ultra-rapid (Lyumjev) & rapid-acting (Fiasp) curves minimal (35 & 50 min) and maximal (100 & 120 min) [...]"

Oref might interprete fiasp as ultra-rapid as well! So we need to check wich oref modell will be used in case of Fiasp. So maybe the wrong model might be selected.

Attach a Log

no log available

To Reproduce

Steps to reproduce the behavior:

  1. Go to 'Settings -> OpenAPS OTHER settings - Insulin Peak Time'
  2. Click on 'Insulin Peak Time' for help text to pop up

Expected behavior

A clear and concise description of what you expected to happen. Depending on the set insulin type in pump settings the correct Insulin curve (and therefore OpenASP curve type) should be set. After this check this help text may need an adjustment.

Screenshots

If applicable, add screenshots to help explain your problem. image

Setup Information (please complete the following information):

Smartphone:

Pump:

CGM:

Trio Version:

Technical Details

If applicable, provide any technical details that might help in diagnosing the problem. This could include logs, error messages, or relevant configuration details.

Additional context

Add any other context about the problem here.

snickerdoodleparent commented 4 months ago

Insulin Peak Time popup came from iAPS. It's problematic because it seems to suggest Fiasp is rapid-acting instead of ultra-rapid and Novolog/Humalog/Apidra aren’t mentioned at all. (It's still wrong in the newest version despite crowdin suggestions.)

Refer to the Trio docs: Insulin Curves rapid-acting: This is a default setting for Novolog, Novorapid, Humalog, and Apidra insulins. Selecting this setting will result in OpenAPS to use an exponential activity curve with peak activity set at 75 minutes and duration of insulin action set at 300 minutes (5 hours). ultra-rapid: This is a default setting for Fiasp. Uses an exponential activity curve with peak activity set at 55 minutes and duration of insulin action set at 300 minutes (5 hours).

I'm pretty sure 75 should be 65, and 55 minutes should be 50 in the Trio docs. @MikePlante1 had found the times in the iAPS code: image

Good catch, this has been long time discussed in iAPS, most of us probably forgot this text is still kicking around.

tmhastings commented 4 months ago

Corrected with PR #348

github-actions[bot] commented 3 months ago

hey 👋 - no triage is done for 30 days 🤐 ... anybody? triage is required!