nightscout / Trio

Trio - an automated insulin delivery system for iOS based on the OpenAPS algorithm with adaptations.
https://docs.diy-trio.org/en/latest/
MIT License
98 stars 531 forks source link

Unify how settings are stored #361

Closed DreyCon-Raphael closed 4 months ago

DreyCon-Raphael commented 4 months ago

Is your feature request related to a problem? Please describe.

When editing settings in Trio subviews behave differently.

Some settings are stored and activated immediatle (I) by leaving the edit field, others need to be saved by pushing a button (B). settings view storing behavior
Preferences (I)
Pump Settings (B)**
Meal Settings (I)
Basal Profile (B)**
Insulin Sensitivity (B)*
Carb Ratios (B)*
Target Glucose (B)*
Autotune (B)***

Despite that this is only a UX thing, I suggest to unify this to always have a save button. This could also be used as a hook to push the new changes to NS.

Describe the solution you'd like

  1. Use the same save button everywhere
    • regardless of whether values are stored
    • only in app for "cosmetically" changes (e.g.: hours displayed on home view)
    • for basic pump behaviour (e.g. offline basal rates) or
    • for oref's needs (e.g. ISF, CR)
  2. prepare a hook for pushing changes to NS with a "valid from" timestamp
  3. (optional) ask for individual notes to the made changes (such as an optional commit message). Users can rethink decisions made based on their notes.

Additional context

Save on Pump image Save image Save as your Normal Basal Rates image

Technical Details

User Impact

dnzxy commented 4 months ago

Duplicate of #98. Closing.