Don't allow entry when entry is already at maximumFractionDigits

nightscout / Trio

Trio - an automated insulin delivery system for iOS based on the OpenAPS algorithm with adaptations.

https://docs.diy-trio.org/en/latest/

MIT License

98 stars 541 forks source link

Don't allow entry when entry is already at maximumFractionDigits #365

Closed MikePlante1 closed 4 months ago

MikePlante1 commented 4 months ago

This makes it so there isn't any weird rounding when entering more decimal places than allowed. Now it just prevents entering more decimal places once the maximum has been entered.

marionbarker commented 4 months ago

Summary

This fixes the "weird rounding"

Configuration

Build Trio dev commit c870190d to SE phone running iOS 17.5.1
Find a "weird rounding" example.
Then apply the patch and test.

Tests

Example:

Type a value with multiple decimal places into

bolus entry with straight dev:
- type 1.555555 and it provides: 1.56, 1.57, 1.58, 1.59, 1.6 etc
bolus entry with patch
- type 1.555555 and it provides: 1.55 and that's it

bjornoleh commented 4 months ago

Merging with two approvals.