GH Build Action warns "Scheduled Sync and Build Disabled" with incorrect information

nightscout / Trio

MIT License

66 stars 355 forks source link

GH Build Action warns "Scheduled Sync and Build Disabled" with incorrect information #387

Open hummelstrand opened 3 weeks ago

hummelstrand commented 3 weeks ago

Describe the bug

When building with action number 4, I get a warning that says "...please follow the instructions under the following path Trio/fastlane/testflight.md" but the path seems to be https://github.com/nightscout/Trio/blob/main/fastlane/testflight.md

Expected behavior

If the warning is relevant, the path information should be updated, and possible hot linked.

Screenshots

Setup Information (please complete the following information):

Trio Version:

Version Number: * 0.2.0 main 6433d94 (https://github.com/hummelstrand/Trio/commit/6433d947ac6abffb4e381c32b59662314b65aa38)
Repo: https://github.com/hummelstrand/Trio

hummelstrand commented 3 weeks ago

Edited to update with what seems to be the correct path to the markdown file.

marionbarker commented 3 weeks ago

Trio does have a fastlane folder and testflight.md is in the folder. My memory is that the error message is not a link, but instructions in how to navigate the user’s fork to find the file.

It is deliberate not to point to the docs because those links are subject to change.

If it is a link, then it should be updated.

hummelstrand commented 3 weeks ago

@marionbarker The warning says "...under the following path Trio/fastlane/testflight.md" i.e. https://github.com/nightscout/Trio/fastlane/testflight.md which results in a 404, since the actual path is Trio/blob/main/fastlane/testflight.md i.e. https://github.com/nightscout/Trio/blob/main/fastlane/testflight.md

bjornoleh commented 3 weeks ago

Sorry for being slightly off topic, but is this info correct? I thought scheduled sync and build was on by default for Trio and also Loop, and that disabling one or both are options? That’s how I read the testflight.md too.

marionbarker commented 3 weeks ago

If workflow is not enabled for GH_PAT, it is disabled.

bjornoleh commented 3 weeks ago

Ok, thanks. I would expect users to follow the instructions and enable the workflow scope, but this probably happens for users that skip that step based on this:

Create GitHub Personal Access Token

If you have previously built another app using the "browser build" method, you use the same personal access token (GH_PAT), so skip this step.