Glucose source unit change update cgmmanagers

nightscout / Trio

Trio - an automated insulin delivery system for iOS based on the OpenAPS algorithm with adaptations.

https://docs.diy-trio.org/en/latest/

MIT License

98 stars 531 forks source link

Glucose source unit change update cgmmanagers #429

Closed dabear closed 1 month ago

dabear commented 1 month ago

This updates the preferred glucose unit for CGM managers when preferences change within Trio, as well as during the creation of new CGM managers.

This closes #40

dabear commented 1 month ago

bjornoleh commented 1 month ago

Very brief testing with G6 and Xdrip4iOS (mmol units) revealed no issues with receiving BG values in the correct units. No access to Libre here, so can't test the fix for units in Lobre-specific BG alerts/notifications.

MikePlante1 commented 1 month ago

Edit: If this is outside the scope of this PR, let me know which repo I should submit the issue to.

Screenshot is from someone else's testing of this PR, not mine... but I noticed the l is not properly capitalized in mg/dL. Also, could the comma be removed between + and mg/dL? And instead of text like Flat use the arrows instead?

dabear commented 1 month ago

Edit: If this is outside the scope of this PR, let me know which repo I should submit the issue to.

Screenshot is from someone else's testing of this PR, not mine... but I noticed the l is not properly capitalized in mg/dL. Also, could the comma be removed between + and mg/dL? And instead of text like Flat use the arrows instead?

Create another issue for that

dabear commented 1 month ago

Libre specific notifications were tested by me btw

Sjoerd-Bo3 commented 1 month ago

My tests:

Trio Dev + #429 on FSL2 Direct Connection set to m/mol:	Trio Dev + #429 on FSL2 Direct Connection set to mg/dl:

Trio TCD + #429 on FSL2 Direct Connection set to m/mol:	Trio TCD + #429 on FSL2 Direct Connection set to mg/dl: