nightscout / Trio

MIT License
71 stars 365 forks source link

Remove `actualDate` as introduced in #22 #55

Closed bjornoleh closed 5 months ago

bjornoleh commented 5 months ago

Proposed in conjunction with https://github.com/nightscout/open-iaps-oref/pull/14

bjornoleh commented 5 months ago

Accidentally created the PR from my fork, but the same branch is available at https://github.com/nightscout/Open-iAPS/tree/remove_actualDate

avouspierre commented 5 months ago

I pushed in the branch remove_actualDate some fix : see https://github.com/nightscout/Open-iAPS/commit/f5d301e28bfcffcc12156340f7bc9d055d6eefe3

Idid some tests described here using the corrected version of oref :

avouspierre commented 5 months ago

the initial branch submodule+oref contains some modified code not included in this PR/branch. I create a new PR : https://github.com/nightscout/Open-iAPS/pull/56

bjornoleh commented 5 months ago

@avouspierre , I guess this is ready to be merged into dev?

avouspierre commented 5 months ago

👍

bjornoleh commented 5 months ago

Thanks! Merging this with two approvals.