search

nightscout / Trio

MIT License
71 stars 365 forks source link

Add branch name and commit hash to the "What to test" field in TestFlight #76

Closed bjornoleh closed 5 months ago

bjornoleh commented 5 months ago

This was originally introduced by @MikePlante1 in iAPS Artificial-Pancreas/iAPS#360

This PR includes a feature for uploading the branch name and git reference as a “changelog” to TestFlight, displayed under “What to Test” for each build. However , there is a bug in AppStore Connect / TestFlight, where fastlane fails to upload changelog if it was never entered before.

The workaround is to make a manual “Test Details” entry from AppStoreConnect (ASC), then build again. Then, the branch and git ref will be displayed under "What to Test" in both TestFlight and ASC.

See https://github.com/nightscout/Open-iAPS/issues/23 and https://github.com/nightscout/Open-iAPS/pull/63 for details.

bjornoleh commented 5 months ago

A version of the workaround for the initial changelog is now documented in https://github.com/nightscout/Open-iAPS-docs/pull/22. Please note an easier workaround is possible too:

Screenshots from building Loop, but the same applies to all:

Click any previous build (provided you already built successfully once): image

Then, enter something (anything) in the Test Details fiels, and hit Save. image

The next time you build, the branch name and commit id should appear as test notes in TestFlight.

bjornoleh commented 5 months ago

Tested and confirmed to work in alpha and also previously in iAPS. Merging this into dev.