search

nightscout / Trio

MIT License
45 stars 127 forks source link

[alpha-issue] - TidePool - Looks like all boluses are labeled as "automated". This highlighted bolus was manual. #77

Open avouspierre opened 2 months ago

avouspierre commented 2 months ago 
          Looks like all boluses are labeled as "automated". This highlighted bolus was manual.

(This test was done via the alpha branch, not specifically this PR, btw)

Tidepool Manual Bolus

Originally posted by @MikePlante1 in https://github.com/nightscout/Open-iAPS/issues/30#issuecomment-2045816305

avouspierre commented 2 months ago

@MikePlante1 I think oiaps doesn't store the origin (SMB or manual bolus) of each dose injected. Probably requires to improve the data model of DoseEntry.

bjornoleh commented 2 months ago

@dnzxy , I believe the distinction between manual bolus and SMB was introduced after v2.3.3, perhaps you were involved in that?

dnzxy commented 2 months ago

Yes. See #93, @BrianWieder is working in bringing that over. I implemented it for iAPS, Brian ported it over (thanks bud!).

It sets a flag, so you should be able to differentiate between SMBs, manual doses and external doses @avouspierre

bjornoleh commented 2 months ago

Yes. See #93, @BrianWieder is working in bringing that over. I implemented it for iAPS, Brian ported it over (thanks bud!).

It sets a flag, so you should be able to differentiate between SMBs, manual doses and external doses @avouspierre

Thanks! I do see theisExternalInsulin flag being set, but not yet isSMB, as far as I can tell. But perhaps that is work in progress (or I missed it) 😊

dnzxy commented 2 months ago

I think Brian will bring that in judging by #93 description.

Follow-up PRs will add the rest of the features for https://github.com/nightscout/Open-iAPS/issues/47

It was part of https://github.com/Artificial-Pancreas/iAPS/pull/267 and later automatic was removed from History view and replaced with SMB 😊

BrianWieder commented 2 months ago

Yes, going to work on bringing over isSMB and displaying it within the history sheet later today.

BrianWieder commented 2 months ago

Created the isSMB flag in #101.

bjornoleh commented 1 month ago

I believe this issue is resolved now? Which PR fixed this?

avouspierre commented 1 month ago

@bjornoleh the correction was done with the PR #104

bjornoleh commented 1 month ago

@bjornoleh the correction was done with the PR #104

Hi, PR #104 was actually closed and not merged into dev. Perhaps it was replaced with another PR, or already merged in alpha? I could however not find anythingh in Trio dev when searching fro isSMB in the TidepoolManager.swift file: https://github.com/nightscout/Trio/blob/dev/FreeAPS/Sources/Services/Network/TidepoolManager.swift

Could you please check if the fix for automated vs manual bolus in Tidepool is indeed included in current dev?