Medtronic Pump connection maxBolus mismatch

marionbarker commented 7 months ago

Issue

This may have been operator error but I was not able to modify settings on iAPS to lower the maxBolus value in the app to connect to a Medtronic pump. I had to modify the pump maxBolus to enable the connection.

default maxBolus for new build is 10 U

Configuration:

iPhone 8, iOS 16.7.5
iAPS v2.3.3(1)
commit f404fc49
Medtronic 515 pump
New build on test phone

Steps:

MDT 515 has maxBolus set to 7
When trying to attach pump, got Max setting exceeded
Modified the iAPS, Pump Settings to Max Bolus of 7 (default is 10 for new build)
Still got connection error (confirmed that iAPS pump settings does say maxBolus of 7)
Modified MDT 515 maxBolus to 10, then could connect
After connection - examined maxBolus on pump and iAPS, both read 7 as desired

bjornoleh commented 7 months ago

Thanks for testing. Is this different from the behaviour in Loop main or dev? We have not updated /Dependencies in a while, and might be lagging behind LoopWorkspace main.

If you have a chance, could you please make the same test with this branch?

https://github.com/nightscout/Open-iAPS/tree/loopkit_main_dependencies

Here, all LoopKit dependencies are up to date with LoopWorkspace main 81a3d9b

bjornoleh commented 7 months ago

It seems like there were only localisations that differed for MinimedKit and rileyling_ios. Hence, I would not expect any differences. There might have been changes in the submodules that are currently used for LoopWorkspace dev. We are looking into updating these as well.

marionbarker commented 7 months ago

I had no problem connecting this same pump with Loop so long as the Therapy Settings for Delivery Limits were the same as or smaller than the Delivery Limits set inside the pump. (I did many tests while updating LoopDocs.)

This pump has been connected to Loop as a test pump at various times over more than a year so has gone through many versions up to current dev.

I believe the problem is in Open-iAPS:

Settings
Configuration Section
Pump Settings has a Save to Pump button at the bottom

I'm wondering if the value is stored at two levels - one the preferences level and one the pump manager (or equivalent) level and if a real pump is not already attached, then modifying the values in preferences does not update the value that will be used when connecting to a pump.

marionbarker commented 7 months ago

Solved

This problem was fixed with branch loopkit_dev_dependencies.

Test Steps

Delete iAPS from the test phone
Build new app
In the app Settings, under Configuration, Pump Settings
- Modified default setting from 10 U to 6 U before connecting to the pump
Connected to MDT 515 (previously configured with maxBolus of 7 U)
- Connection was successful on first attempt
After connecting to the MDT 515, I confirmed that the maxBolus on the pump was now 6 U

Configuration:

iPhone 8, iOS 16.7.5
iAPS v2.3.3(1)
commit 4932f701, branch loopkit_dev_dependencies
Medtronic 515 pump
New build on test phone

Other notes:

I was not successful building with branch loopkit_main_dependencies.

marionbarker commented 7 months ago

I will close this Issue as soon as the fix is incorporated into main and I repeat the successful text.

marionbarker commented 6 months ago

I will repeat this test for alpha now that we are using submodules.

marionbarker commented 6 months ago

Completed

This issue can be closed. With a new app, values were successfully modified from the defaults and used when connecting to an MDT pump.

Configuration:

iPhone 8, iOS 16.7.7
Open-iAPS 0.1.0 (1)
alpha, commit 99effeb
Medtronic 515 pump
New build on test phone

Steps:

MDT 515 has maxBolus set to 7, maxBasal rate set to 0.9 U/hr, scheduled basal rate set to 0.5 U/hr
In new app, defaults are 10 U, 2 U/hr and 1.0 U/r respectively
- Modify Pump Settings to max of 7 u and 0.9 U/hr
- Set scheduled basal to 0.4 U/hr
Connect app to pump, took several attempts but that's pretty common (just added a battery)
- quit/rebuild, power cycle riley, success
read pump settings on pump
- They match the values adjusted in the app before attempting to connect with the pump

While I'm here, confirm https://github.com/LoopKit/Loop/issues/2137 is fixed (it should be because MinimedKit has been updated). Success:

MDT screen shows basal rate of 0.4 U/h.
Change basal settings in app to 0.5 U/hr.
The basal rate on display matches the new rate.

nightscout / Trio