nightscout / Trio

MIT License
67 stars 359 forks source link

[alpha-issue] - App crash related to calibration #92

Closed bjornoleh closed 4 months ago

bjornoleh commented 5 months ago

OiAPS crashed.

Build: alpha de9cd832288f8b456c2aad22d81033f95f946c19

The sequence of events might have been different, but it apparently happened when selecting Glucose Direct and trying to open the app when it's not installed.

To reproduce: Select Glucose Direct from GCM value Tap Open Glucose Direct

--> App crash, force close does not resume operation of the app (black screen)

image

The crash only happened on first attempt, after a rebuild/launch from Xcode, a warning popped up: image

bjornoleh commented 5 months ago

According to @avouspierre , the issue is not related to glucose direct but seems an issue with calibrations at the first start.

Renaming the issue.

bjornoleh commented 5 months ago

I think we can consider this issue solved by #94, there has been no more reports of the app crashing. Closing this for now, will reopen if needed.

bjornoleh commented 4 months ago

@avouspierre , I am seeing this issue again, or at least I think it might be the same:

image

Simulator build in Xcode 15.0 to iPhone 15 Pro simulator.

Do you need any more info? I will have to rebuild to get the app to respond and check settings.

marionbarker commented 4 months ago

What actions did you take post build? I built commit aa552717 to a simulator and it hasn't crashed.

Edited to add - had not build to this simulator before, so all default settings. Most of my builds are to a test phone.

bjornoleh commented 4 months ago

No actions taken except launching the app.

Pump simulator CGM simulator Default settings + raised Max IOB, Closed loop, no dynamic settings.

No services configured (NS, Tidepool, Apple Health)

avouspierre commented 4 months ago

Seems a new bug with the process queue. I will try to reproduce it. The crash occurs with the current alpha version with the configuration described @bjornoleh ?

bjornoleh commented 4 months ago

Seems a new bug with the process queue. I will try to reproduce it. The crash occurs with the current alpha version with the configuration described @bjornoleh ?

Yes, the build I did was just alpha with SMB schedule fixes, so basically alpha. The crash did not happen spontaneously on next build of the same branch, so not sure exactly how to reproduce.

avouspierre commented 4 months ago

Succeeded to reproduce the issue and fix proposed in #142 PR

bjornoleh commented 4 months ago

That’s great. How did you reproduce it?

avouspierre commented 4 months ago

Fresh install. The issue is done because the process Queue is not yet created if I understand well.

marionbarker commented 4 months ago

I just got this error with a fresh install. but then could not reproduce it by deleting the app and installing again. However, PR #142 has not been merged so don't know if that would have prevented this.

bjornoleh commented 4 months ago

This issue has not been reported after merging of https://github.com/nightscout/Trio/pull/142, so I think we can consider this to be fixed.