nightscout / Trio

MIT License
66 stars 349 forks source link

Temp target duration fix #95

Closed kylmcw closed 5 months ago

kylmcw commented 5 months ago

FIxed the temp target duration to be more dynamic when passing any number not null. Refactored messages to be more consistent when addressing user for temp targets. Renamed references to "Temp Target" to be more consistent from "Temp Preset" fixed OiAPS references in a few classes to Open-iAPS

Steps to reproduce:

Evidence of fix:

Target 'Temp Test' applied for 2hrs Target 'Minutes test' applied for 5min Target 'Odd minutes' applied for Confirm to apply temporary target
kylmcw commented 5 months ago

Suggestion: We could make the function public, move it to a utility function and apply it in places where "min" or similar is hard coded

dnzxy commented 5 months ago

I have no experience with iOS shortcuts, so I‘ll omit doing a review. Your changes look reasonable and limited, so sensible.

bjornoleh commented 5 months ago

Thanks! Please remember to create the PR to dev as well when this is tested in alpha, as we do not plan on merging alpha into dev.