Pushover not working properly

[oamyoamy]

Been noticing for a while that Pushover is not behaving properly...

-- doesn't matter if certain things are turned off (like alarms or error codes), you get them all -- ack'ing from Pushover doesn't always snooze properly (ack'ing from site works fine)

[oamyoamy]

Alarms like CAGE are also not triggering either alerts (in site) or Pushover notifications.

[jasoncalabrese]

Is this with master or dev, I think there are several issues, I got a CAGE alarm for the first time in a long time last week, so there are some conditions that can make it work...

1 of the issues that I'd really like to fix is there are only 2 types of alarms urgent and warning, if you ack an urgent alarm you ack all alarms for that time period.

[oamyoamy]

Running dev.

Beyond CAGE issue, I don't find that the settings to control pushover are working.

I have PUSHOVER_ALARM_KEY set to off... still get all alarms.

I have ERRORCODES_URGENT set to off... still get alarms for ??? every 1-2 minutes via pushover

[jasoncalabrese]

I think I see the issue here, there was a change to treat 'off' as false, but pushover code wasn't updated

[sulkaharo]

I've actually observed the pushover notifications randomly (but rarely) being triggered by the backend when the client data indicates they should not have. Wonder if the OpenAPS IOB is causing issues with the IOB snooze?

[jasoncalabrese]

That might be a different issue, I think the iob plugin starts ignoring devicestatus iob after it get old, I think we should extend that period and then have a fallback to treatment based iob.

[jasoncalabrese]

@oamyoamy I think this is really fixed now, there were multiple issues but it's been working in my tests for last week or so. I've also added some extra logging for notifications so if we see anything else strange it might be easier to debug.

[oamyoamy]

Just got a CAGE alarm, Jason. First time in a long time!

[jasoncalabrese]

Great, keep an eye on alarms in general