search

nightscout / cgm-remote-monitor

nightscout web monitor
GNU Affero General Public License v3.0
2.42k stars 71.79k forks source link

COB is always zero when rewinding/scrolling back #5241

Open naromero77 opened 4 years ago

naromero77 commented 4 years ago

Describe the bug I believe this worked in the recent master but not in dev. The current COB pill displays correct value and updates correctly as time progress. However, if you rewind/scroll back the NS viewer you to a prior time the COB pill always displays zero.

To Reproduce Set-up is NS dev from a couple of weeks ago. Recent version of Loop dev.

Take NS viewer in a Firefox or another browser and just scroll back: COB is displaying zero, but the current instantaneous COB is correct.

Expected behavior If you rewind/scroll back the NS viewer, I expect the COB displayed to show the correct value at the prior time.

Screenshots If applicable, add screenshots to help explain your problem.

Your setup information

Additional context I can add a screenshot, but it would not be interesting. It should always shows "0" in the COB pill when you scroll back. In the present time, COB is displaying correctly.

woodduckie commented 4 years ago

I've observed this issue after updating to v13. I can't be certain it wasn't there before and I haven't yet had the time to roll back my deployment. To add to the original issue, IOB reflects historical values when scrolling, but COB just shows 0. FWIW, I'm using loop, Firefox /Safari, G6 via bridge.

Sophieinthecloud commented 4 years ago

NS_COB

I'm having this same issue. When scrolling back in time, The COB shows in the Loop pill when I click it but the COB pill shows 0(see screenshot #1). A new bolus does show the COB (see screenshot #2).

I'm not exactly sure when it started but I first noticed it after I cleaned mLab. Not sure if that is related or a coincidence. NS_COB2

bjornoleh commented 3 years ago

@sulkaharo I believe this was mentioned in CGM in the cloud quite recently. Not sure why the issue was closed just now, it still could use some attention.

https://github.com/nightscout/cgm-remote-monitor/issues/6916 mentions a possible fix for that particular issue: COB: buggfix to show history COB when scrolling the timeline backwards

naromero77 commented 3 years ago

It looks like the bug fix should go in the DIY software which is uploading information into NS. Thus the fix would have to go into OpenAPS, AndroidAPS, and Loop.

sulkaharo commented 3 years ago

@naromero77 Nope, this is a bug in the COB plugin not fetching the COM data from the device statuses when timeline is being scrolled.

jgefaell commented 1 year ago

This behavior is still present in Nightscout 14.2.6

It would be very appreciated if it could be addressed. Thank you.

bjornoleh commented 1 year ago

The fix mentioned in #6916 still works great

bjornoleh commented 1 year ago

I copied the fix mentioned previously, and created PR #8081. Credits to @klalle / @maja-lofgren

pinging @bewest and @sulkaharo in case this gets lost in the git spam.

bewest commented 1 year ago

Thanks, @bjornoleh!