Cleaner report-charts - Githubissues

maja-lofgren commented 3 years ago

Describe the solution you'd like I'd like the graphs to be cleaner when viewing insulin, carbs, iob and cob. I mocked around in the code and made a suggestion which I ended up using on my nightscout since it makes it allot easier to read. Changes that works for me:

moved the named graphs up to 1/3 of the chart instead of starting at the bottom
changed the bar-width on insulin and carbs
moved insulin-text and rotated it +45deg instead of -45
Added notes to the treatments
Added insulin activity (red line) from openaps - (not in this request-scope)
See screenshot of my example bellow
This is my mock-code so far (branched out from dev) my branch diff compared with dev-branch

Additional context

I dont really have the time to clean up the code/make it 100% compatible with iphone loop/do required tests to make a pull request, but in my branch you'll see my ugly hack that works for AAPS anyways =)

sulkaharo commented 3 years ago

Looks promising! Wonder if the COB and IOB plots would be better placed below the basal plot, so it won't overlap the CGM plot when the CGM data has higher spikes?

maja-lofgren commented 3 years ago

Looks promising! Wonder if the COB and IOB plots would be better placed below the basal plot, so it won't overlap the CGM plot when the CGM data has higher spikes?

That's an idea, but for me, I think I prefere a solution where its not taking any more vertical space (helps when viewing several days) The CGM overlaying the iob/cob curves is not really a problem:

sulkaharo commented 3 years ago

Heh, you should assume we also have users with the entire CGM plot in the 10 - 20 range. ;) If we touch this, I think the design really needs to make an attempt at reducing the amount of overlapping plotting, where having the CGM, basal and COB/IOB should have separate areas on the plot. Note the CGM plot uses a linear scale, while the real time plot uses a nonlinear plot that compresses the values outside the range and it should be possible to actually reduce the height of the CGM plot quite significantly if we change the axis scale for the plot.

bjornoleh commented 3 years ago

It would be nice to also have y-axis scales for basal and active insulin. Currently it is very hard to get an idea about the range of these values in the Day to day report. The right hand axis is not in use, so could be used for basal and IOB

nightscout / cgm-remote-monitor

Cleaner report-charts #6882