nightscout / cgm-remote-monitor

nightscout web monitor
GNU Affero General Public License v3.0
2.39k stars 71.64k forks source link

OpenAps features visible in pillar #6916

Open maja-lofgren opened 3 years ago

maja-lofgren commented 3 years ago

I just want to share a fiew tweeks that I've made to my NS that helps allot in visualizing important data.

Describe the solution you'd like Modifications I've implemented:

image

Additional context My code is not properly tested, and might fail if not used by AAPS.... more lika a proof of consept! my branch diff against dev

bjornoleh commented 2 years ago

Hi @maja-lofgren

I tested two of your individual commits now:

Both of these seems to work well here. Thanks for this!

We are not using AAPS, so can't test the "IOB: Added the activity" patch.

I also could not identify the relevant commit(s) for "OpenAPS: Added current Target (T), ISF, CR and sensibility ratio (sr)". I might test it later, but it will also take up a lot of space in NS (on a phone), so not sure if I 'd use it.

I am not involved in NS development, but would encourage you to prepare branches for your patches to allow PRs to NS dev. Please keep your PRs as small as possible, without bundling too much into each one. And start off with at clean branch that is even with dev.