Open maja-lofgren opened 3 years ago
Hi @maja-lofgren
I tested two of your individual commits now:
Fix to display historic COB-value (from OpenAps) when scolling back in time https://github.com/nightscout/cgm-remote-monitor/commit/7aa606ddac735fce821119e5bb674c08bc8441f0
Added profile basal rate in () next to current temp basal https://github.com/nightscout/cgm-remote-monitor/commit/58495f788f68fd2810e2b59725d14b19f3425398
Both of these seems to work well here. Thanks for this!
We are not using AAPS, so can't test the "IOB: Added the activity" patch.
I also could not identify the relevant commit(s) for "OpenAPS: Added current Target (T), ISF, CR and sensibility ratio (sr)". I might test it later, but it will also take up a lot of space in NS (on a phone), so not sure if I 'd use it.
I am not involved in NS development, but would encourage you to prepare branches for your patches to allow PRs to NS dev. Please keep your PRs as small as possible, without bundling too much into each one. And start off with at clean branch that is even with dev.
I just want to share a fiew tweeks that I've made to my NS that helps allot in visualizing important data.
Describe the solution you'd like Modifications I've implemented:
Additional context My code is not properly tested, and might fail if not used by AAPS.... more lika a proof of consept! my branch diff against dev