search

nightscout / cgm-remote-monitor

nightscout web monitor
GNU Affero General Public License v3.0
2.38k stars 71.59k forks source link

Nightscout should not use Google Fonts #8079

Open gardenrobot opened 1 year ago

gardenrobot commented 1 year ago

I propose Nightscout should self-host fonts, instead of using a 3rd party to serve them.

I have run into issues with my homeserver where Nightscout became unusable due to an internet outage. If Google Fonts is not available for whatever reason, it would break Nightscout. There is also the issue of privacy, as Google uses fonts to collect data.

As far as I know, using Google Fonts doesn't offer much benefit to a project like this, where deployments are for a small set of users. I could be missing something though.

I have checked the licensing and Ubuntu and Open Sans both allow for them to be used in the repo.

If this change sounds good, I can implement this and create a PR. I have already created a quick POC. An alternative could also be to have self-hosted fonts as a fallback to Google.

sulkaharo commented 1 year ago

Sure, if you can check and show the license allows for this, please make a PR. And please check how the caching of the fonts works, one reason to use the Google fonts is they're cached quite well and using them improves the site responsiveness most of the time.

gardenrobot commented 11 months ago

Sounds good. The PR has been made. Is there a process or someone to ping to get a review?