nightscout / cgm-remote-monitor

nightscout web monitor
GNU Affero General Public License v3.0
2.38k stars 71.59k forks source link

NS DEV v15 Profile editor buttons missing #8107

Open szantos opened 11 months ago

szantos commented 11 months ago

On entering profile editor, the buttons show up for a moment, then disappear:

2023-10-13 083815

Similar to #7947

NS DEV v15 2757fe585d51dbf6972f26a89291593bee476df3

justmara commented 10 months ago

same here. issue is actual for NS 15.0.1 (and for 15.0.2 from this dev image too

robinsondan87 commented 10 months ago

I have the same issue with this on 15.0.1, thought it was just me so reassuring im not the only one.

bewest commented 10 months ago

Confirmed. Git bisect points to one of my changes as the cause: https://github.com/nightscout/cgm-remote-monitor/pull/8085/commits/9f2f98b76ad4c123a6063b453ef071e6319a2310

I can confirm that removing this change restores the previous behavior. Removing this change also causes Nightscout to ask for API Secret, even if Nightscout is readable. This causes the modal prompt to come up any time visiting a readable site, as well as a new modal prompt for any restart/reconnect after dismissing the modal.

bewest commented 10 months ago

Potential fix available, needs further testing: https://github.com/nightscout/cgm-remote-monitor/pull/8132

someguygg commented 10 months ago

Potential fix available, needs further testing: #8132

Works! This was an issue for a long time. Working well on 15.0.2-Dev.