search

nightscout / cgm-remote-monitor

nightscout web monitor
GNU Affero General Public License v3.0
2.38k stars 71.59k forks source link

This fixes the issue of a "stale" CGM value displaying indefinately. #8108

Open gth001 opened 10 months ago

gth001 commented 10 months ago

…It displays "Internet offline." until internet is restored.

This fix addresses the issue that with a lost internet connection, clock view continues to display a stale CGM value forever, with no clue that internet connectivity is lost. This fix shows "Internet offline." for the duration that is it lost, then returns to normal when internet is restored.

bjornoleh commented 10 months ago

Hi @gth001, I saw your message on Discord. You should first change the target branch to dev. Then you should also rebase the PR onto dev, or merge dev into your branch. Or you can start over with dev and apply your changes there and make a new PR.

I hope your fix is a good one that can be merged, I have seen this issue myself.

There are lots of erroneous PRs being made to master when people try to update their forks. If you think your PR is being overlooked, you could try to ping one of the core developers like bewest or sulkaharo. Use @ to tag the usernames I mentioned.

gth001 commented 10 months ago

You should first change the target branch to dev. Then you should also [...] merge dev into your branch.

Thank you, done.

I have been using this fix for a year or two now, successfully. I have Amazon Fire tablets around my house always showing clock view, and sometimes they lose their wifi connection. Since railway stopped being free, I switched to fly.io but forgot to re-add this fix until I noticed a stale clock at home. So I forked, added the fix again, pointed to my fork, and deployed again to fly.io. Here is the fix in action:

https://github.com/nightscout/cgm-remote-monitor/assets/10224533/1738963c-d2c6-49ff-8e4b-b747ca453efb

(By the way @bewest I am George Francis on facebook, if you remember me, we chatted sometimes.)