nightscout / nightguard

iOS and WatchOS Client for the Nightscout CGM System
GNU Affero General Public License v3.0
234 stars 158 forks source link

Improvements to care tab #140

Closed aliswalker closed 2 years ago

aliswalker commented 3 years ago

1) Can carb entry on the app and watch be free text (with a keypad on the watch)?

2) TT target values in mmol/L are odd increments - 4.0, 4.5 etc would be better

3) feature request: pre defined TTs would be nice (like in AAPS) but not essential

dhermanns commented 3 years ago

Hi Alis!

1) I think the entering by keypad is inconvenient, especially on the watch.

2) This is because mg/dl is what is used by the nightscout backend internally. Mmol is just calculated for the UI.

3) you mean like: "Too Low" = Target x mmol. You can change the "x" on the iphone app. Next time you select "Too Low" x should be automatically what you selected last time?

aliswalker commented 3 years ago

3 Great! Haven't tested this yet

2 So what needs to change to get around this? If AAPS can set a TT in mmol which shows in NS, there must be a way?

1 The increments aren't very convenient so we have to add multiple entries to get e.g. 48g (45 + 3). So my suggestion is to use a keypad - alternatively start at 1g and increase in 1g if you want to keep the slider? Keypad is no different to AAPS carb entry eCarbs (duration) would also be awesome but it's early days!

dhermanns commented 3 years ago

3) no this doesn't work this way now. Just wanted to know if that's what you thought off.

2) I would need to implement different targets for mmol and mgdl. So you get nice rounded targets for mmol and mgdl. Quit some work.

1) I'm quite impressed how accurate you enter your carbs ;-). I'm not able to calculate them that exactly. So 5g seems to be fine for me. And it's faster to enter if you don't have to enter them exactly. Rest is up to AAPS ;-).

dhermanns commented 3 years ago

If point 1 seems helpful to you, I will consider implementing it this way.

aliswalker commented 3 years ago

Please. It would definitely be useful, especially as we close the loop further, ie no pre bolus and just carb entries. Meal entries are probably my most frequent & time consuming task nowadays!

There are probably some further UI tweaks for the watch (eg move settings to the end and hide stats under a button press) but I'm glad to see it functions

dhermanns commented 3 years ago

It will be available with Build 664:

https://testflight.apple.com/join/Ub8WcpcE

aliswalker commented 3 years ago

When you mentioned considering point 1 did you mean the TTs or carb entry?

I leave the management of carbs 100% to AAPS and rarely pre-bolus (just use TT) but it relies on me being precise with carbs to start with. So carb time and value are very important to me.

Along with precise 1g carb entry (maybe as a Preference ie basic/advanced carb scale) is it possible to set carb time please?

dhermanns commented 3 years ago

I implemented the default TT. Should work now on TestFlight.

aliswalker commented 3 years ago

Great, I will test the changes I made next time.

Is the carb entry going to change?

dhermanns commented 3 years ago

No - still don't believe that a keyboard to enter gramms on the watch has a good user experience. Sorry.

aliswalker commented 3 years ago

You say it wouldn't be a good UX but that's exactly how AAPS works?

If you disagree, what about 1g unit increments? At the moment as a workaround I have to enter 2 separate entries for anything ending in 3g, 6g, 8g or 9g.

Meanwhile entries ending in 1g, 2g, 4g, 7g are impossible... I notice another user requested the same on #138 (1-100g)

dhermanns commented 3 years ago

You mean the Aaps Watch UI? Or the Phone UI? On the phone the direct entering is OK for me. If I remember the watch UI right, you have to press and hold a + button. I don't find that very comfortable there, too.

dhermanns commented 3 years ago

Maybe a good compromise is to have 1,2,3,4,5,6,7,8,9,10,15,20,25 and so on.

This way you can be precise till 10g. But still don't have to scroll very much.

aliswalker commented 3 years ago

Maybe a good compromise is to have 1,2,3,4,5,6,7,8,9,10,15,20,25 and so on.

This way you can be precise till 10g. But still don't have to scroll very much.

Yeah that would fix the issue, not easier but more accurate :)

dhermanns commented 3 years ago

Have a look at the testflight coming up next. Should be available in a couple of hours. Cheers ;-) .

aliswalker commented 3 years ago

As an idea to enable precise carbs in one entry, how about 3x single-digit pickers on one row? Eg 1/2/3g

It could still default to 0/0/0g so there's no bias if you want to enter rounded figures (50g for example)

(Let me know if there's a separate TestFlight for Alpha releases)

dhermanns commented 3 years ago

Yes - would be an option. But if we hava UI Control in Eureka and Swift UI for that.

The TestFlight version is here:

https://testflight.apple.com/join/Ub8WcpcE

prakashdevadas69 commented 2 years ago

Hi, I am using Nightguard and I am not able to enter care data. I get error ‘you don’t have write permission to Nightscout site’. I have enter security token in the URL. Any help from anyone pls.. ![Uploading 7E652403-E867-4FF0-8E24-739951582F8B.png…]()

dhermanns commented 2 years ago

Hard to say. Can't see your image. I would expect that your Token isn't correct. You can try e.g. to add carbs using the nightscout web application in combination with your token.

prakashdevadas69 commented 2 years ago

Hi, thanks a lot for the response. I am able to modify care data from Nightscout using the same token. But from Nightguard I am getting this error 944D0BDE-073B-40DB-BBA0-04924888D194

prakashdevadas69 commented 2 years ago

Care data entered from Nightscout is visible on Nightguard

prakashdevadas69 commented 2 years ago

5654B4B3-6E28-435D-81A8-05DBCB33D18E

prakashdevadas69 commented 2 years ago

My Syntax url in Nightscout is as below https://nightscout.herokuapp.com?token=mytoken

dhermanns commented 2 years ago

That looks fine. You could generate a token for me, if you like. You could send it to

@.***

And I will have a look whats going on there ;-)

prakashdevadas69 @.***> schrieb am Sa. 22. Jan. 2022 um 16:42:

My Syntax url in Nightscout is as below https://nightscout.herokuapp.com?token=mytoken

— Reply to this email directly, view it on GitHub https://github.com/nightscout/nightguard/issues/140#issuecomment-1019294684, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAYPBFOJ6OURUXRHFSZQYRLUXLF5BANCNFSM4VNQR77Q . You are receiving this because you commented.Message ID: @.***>

dhermanns commented 2 years ago

No problem. I will have a look.

prakashdevadas69 commented 2 years ago

Thanks a lot

dhermanns commented 2 years ago

I had a look at the response your nightscout backend sends: Its a HTTP 401er, which means it should be the token that's causing troubles. What role is assigned to this token. It should be "careportal":

image

dhermanns commented 2 years ago

And better open up a new ticket next time ;-).

prakashdevadas69 commented 2 years ago

Thank you so much .. I am able update careportal data after changing API_SECRET with access token generated Thank you for making this App which is making Us to manage Type-1 easily. God bless you all..Keep up your good work for mankind..

dhermanns commented 2 years ago

Excellent ;-) !

prakashdevadas69 @.***> schrieb am Mo. 24. Jan. 2022 um 02:33:

Thank you so much .. I am able update careportal data after changing API_SECRET with access token generated Thank you for making this App which is making Us to manage Type-1 easily. God bless you all..Keep up your good work for mankind..

— Reply to this email directly, view it on GitHub https://github.com/nightscout/nightguard/issues/140#issuecomment-1019633639, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAYPBFNCS26FXWRQPWPY4V3UXSUABANCNFSM4VNQR77Q . You are receiving this because you commented.Message ID: @.***>