search

nightscout / nightguard

iOS and WatchOS Client for the Nightscout CGM System
GNU Affero General Public License v3.0
243 stars 159 forks source link

Check BG every minute toggle not working on iPhone APP #314

Open Uksa007 opened 1 month ago

Uksa007 commented 1 month ago

Hi,

Using Nightguard iOS APP V3.29.2.906 (latest?) on iPhone

My Nightscout(web page) updates its data every one minute from the Libre 2 Sensor.

When I turn on the "Check BG every minute" toggle in the iOS APP Preferences, it still only updates every 5 minutes, not every minute!

I have tried restarting the iOS APP. Removing and reinstalling the iOS APP.

Is there anyway to get Nightguard to update every one minute?

dhermanns commented 1 month ago

@poml88 Any thoughts?

poml88 commented 1 month ago

Not really. So, it is not working on the phone? The watch? Both? And Nightscout shows a new value every minute? This is the official release from the app store?

Codewise, we just change the 5 for a 1, the rest remained the same... Maybe something with UserDefaults, does not remember the setting.

Btw, @dhermanns did you get my email? I sent you an email a while ago... :)

Uksa007 commented 1 month ago

Not really. So, it is not working on the phone? The watch? Both? And Nightscout shows a new value every minute? This is the official release from the app store?

Codewise, we just change the 5 for a 1, the rest remained the same... Maybe something with UserDefaults, does not remember the setting.

I'm testing on the iPhone. Don't have a watch to test. Using the official release from the app store.

Can you test, even if your sensor doesn't update every minute it should still check and update the time last checked beside the BG value, with the "Check BG every minute" toggle on? MIne is always 5min before the BG is changing and the time last checked then goes back back to 1min.

Regards

poml88 commented 1 month ago

Ok, thanks. I can test it on my setup, I have a Libre 3.

poml88 commented 1 month ago

Ok, same here. Seems the phone app is doing something differently and ignoring the one minute option. It did work on the watch so. I guess I never noticed, because I only cared about the watch. However, I never tried the app store offical release. I only tried my own builds.

Uksa007 commented 1 month ago

Ok, same here. Seems the phone app is doing something differently and ignoring the one minute option

Thanks for testing and confirming that this is indeed a bug.

How to progress fixing? Who wrote the code for the Check BG every minute toggle, are they able to test and fix for the iPhone?

Regards

Evs-nazgul commented 1 month ago

I noticed the samenissue on my iwatch 7, a value is shown next to the BG, but the watch does not update every minute

dhermanns commented 4 weeks ago

@poml88 have you been able to achieve something here?

poml88 commented 4 weeks ago

No, not yet. It used to work great on my watch and since then no code changes. It is a bit strange. my own TestFlight is still valid, I can try to install that. Or maybe the user experiencing problems shall try to install that on their side, because that build worked great. just tested, works great on my testflight. I submitted it for external testing review. Don’t know, it does not seem to work on your code tree, did you change something?

https://testflight.apple.com/join/dyfTHeDx

dhermanns commented 4 weeks ago

There are always changes, but not directly connected to the 1 minute updates. The whole project has been updated to iOS 18. That could alone be a reason for every kind of problems ;-).

I cannot guarantee the quality of that feature, since I don't have the hardware to test it in a real world environment.

You should use nightguard as your upstream project and take care of the feature.

poml88 commented 4 weeks ago

Yes, sorry, well, maybe it is better to remove that feature. It was a contribution and I am happy to help, but the wind is quite hefty here in this project, which I guess is necessary to keep the thing kind of in order.

That is part of why I started my own app. There I have a bit of creative freedom. I sent you an email about this but it seems you did not get it.

Happy to look into this, but next week I have to cross the alps with the dog and will be far from any Xcode.

I guess something went wrong with the PR. Have to find out what is missing or remove the thing.

dhermanns commented 4 weeks ago

Too bad - that was why I asked if you are able to support this feature since I can't.

We will have to remove it if no one else in the community wants to assure the quality of this (for a longer time) :-/.

poml88 commented 4 weeks ago

I look at the code. No idea. The PR was quite small, three files few lines. Those lines are still in the current code. It does work fine when I build it and in my testflight. It does not seem to work fine in your app store version. I do not know why it is not working. Maybe something wrong with your app store build.