Open billyjbryant opened 8 months ago
Is anyone going to review this? It has been in for 6 weeks with no review or comment.
Definitely safe to merge this, the var last_updated doesn't appear to be used at all throughout the rest of the script. In any case adding the ternary operator makes perfect sense.
This line may not even be needed, or it may for some future plans.
Just to be safe, I have also tested with this updated and confirmed working, although I couldn't recreate the problem locally either way, i can see that this could cause the problem stated.
@bewest approval is required to merge.
Description
When the connect plugin pulls data for Libre LinkUp, if
last_known
isnull
, the plugin crashes with the following error, causing a reboot loop on the container:This is fixed by adding in appropriate checks to ensure that direct reference to an
undefined
var are not performed and thus prevents the system from crashing.fixes: #27