search

nightscout / nightscout.github.io

website, meta repo for whole project
GNU General Public License v2.0
107 stars 233 forks source link

Adding "Rooting is OPTIONAL" section to the top of this guide. This describes the benefits of rooting and provides a link to a rooting guide on Lifehacker. #19

Closed brianhanifin closed 10 years ago

brianhanifin commented 10 years ago

This pull request has been automatically generated by prose.io.

jasoncalabrese commented 10 years ago

@brianhanifin, @bewest, the travis build for this failed, the error says:

./build.sh: line 5: GIT_EMAIL: unbound variable

I'm thinking that isn't the real error, and it's something unrelated to this? Maybe the change to tags?

jasoncalabrese commented 10 years ago

I see other pages have tags defined the same way, so thats not it. I also see that other PR's had this problem before they were merged, so maybe it's just something with the way Travis is configured for PR's. @bewest should we just merge?

brianhanifin commented 10 years ago

I tried editing the page in prose.io. I've never done that before...Why would a page edit with very little markdowns cause an error.

Oh, it could be from when I tried to submit the prose.io change before I authorized it with my github account.

Brian

On Jun 15, 2014 10:59 AM, "Jason Calabrese" notifications@github.com wrote:

@brianhanifin, @bewest, the travis build for this failed, the error says:

./build.sh: line 5: GIT_EMAIL: unbound variable

I'm thinking that isn't the real error, and it's something unrelated to this? Maybe the change to tags?

— Reply to this email directly or view it on GitHub.

bewest commented 10 years ago

Don't worry about the error, it's fine.

It is failing to modify the actual pages because it's not master and doesn't have permission to do so from forks. This is expected, but is erroneously reported as an error because it quits the build in an unclean way, my apologies!

bewest commented 10 years ago

Many thanks!