nightscout / nightscout.github.io

website, meta repo for whole project
GNU General Public License v2.0
107 stars 233 forks source link

Improper encoding of special characters when using API auto configure tool #59

Closed HandwovenBox closed 3 years ago

HandwovenBox commented 6 years ago

During configuration of the uploader app on my Samsung Galaxy S5, I used the API auto configure tool (http://nightscout.github.io/pages/configure/) to enter the URL and API secret into the uploader app.

My API secret includes special characters (for example, a "#", "%", or "$"). After completing setup, the app wasn't uploading data--it returned an error that indicated an authorization issue. When I reviewed the app settings, I realized that each special character had been converted to its encoded "%23", "%24", or "%25" which caused the error.

For example: auto_configure_nightscout_-_2018-07-08_01 34 41

This occurred while I was using the 600SeriesAndroidUploader app but I imagine that it would be a problem regardless of the uploader app.

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/60612524-improper-encoding-of-special-characters-when-using-api-auto-configure-tool?utm_campaign=plugin&utm_content=tracker%2F2443593&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F2443593&utm_medium=issues&utm_source=github).
psonnera commented 3 years ago

Documentation updated to recommend not using special characters (difficult to handle with REST API). https://nightscout.github.io/nightscout/new_user/#step-4-fork-and-deploy-cgm-remote-monitor