search

nightscout / nightscout.github.io

website, meta repo for whole project
GNU General Public License v2.0
104 stars 228 forks source link

improve docs #74

Closed Jitendra-singh-123 closed 3 years ago

Jitendra-singh-123 commented 3 years ago

please,can u accept my pull request?

Jitendra-singh-123 commented 3 years ago

Can u do it for me? Please

On Wed, 30 Sep 2020, 8:43 pm Stephen Brown II, notifications@github.com wrote:

@StephenBrown2 commented on this pull request.

In docs/css/admonitions.css https://github.com/nightscout/nightscout.github.io/pull/74#discussion_r497590728 :

@@ -1,3 +1,4 @@

  • / About CSS */

I'm not sure how this improves the docs?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/nightscout/nightscout.github.io/pull/74#pullrequestreview-499539846, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQMLB32O6Y47KGN42HDTWEDSINDI3ANCNFSM4R7GXDUA .

StephenBrown2 commented 3 years ago

Unfortunately, no, as I'm not a maintainer, and it's still unclear as to what this improves. You haven't provided a description in the PR, and the only change is an extremely indented comment.

StephenBrown2 commented 3 years ago

This seems to be an invalid/spam PR, and I recommend closing it and tagging it with the aforementioned tags, as recommended by DigitalOcean's Hacktoberfest FAQ: https://hacktoberfest.digitalocean.com/details#quality

Spammy pull requests can be given a label that contains the word "invalid" or "spam" to discount them. Maintainers are faced with the majority of spam that occurs during Hacktoberfest, and we dislike spam just as much as you. If you're a maintainer, please label any spammy pull requests submitted to the repositories you maintain as "invalid" or "spam", and close them. Pull requests with this label won't count toward Hacktoberfest.