marionbarker
commented
3 months ago Summary
- The pdf is value added, not sure about the epub
- Approving as is, but see comments
Comments
It took me a bunch of tries to figure out where to go to find the download buttons. (Answer - tap on the ReadTheDocs logo on lower right to get the menu with downloads to show up.)
epub
The epub download was an actual download.
- I downloaded an epub reader and the file was readable but figures didn't show up and links look odd
- The search function worked
- I am not sure including the epub option is value added
The pdf download opened in the browser without automatic download and had the save page as to get it stored to disk. (Note - this may be a positive feature.)
- The pdf format is preferred in my opinion
- The links all worked
- Figures that are added by using the relative address img/figure-name showed up
- Figures that were added with an absolute address did not - but these should all be scrubbed from the Trio docs any way
If we want this to be a hidden feature with both epub and pdf, this is fine. And I will approve it as is.
aug0211
Per @pheltzel & @Sjoerd-Bo3 ’s request, I added PDF as an option for the docs. I also added epub since it was in the same guide, but am not familiar with that format so let me know if it’s useful or if I should remove it and only offer pdf.
I guess I should have used a different name for the branch, but oh well: https://oidocs-mikeplante1.readthedocs.io/en/pdf/