search

nightscout / trio-docs

GNU Affero General Public License v3.0
9 stars 12 forks source link

corrections to Authentication for Bolusing section #43

Closed snickerdoodleparent closed 3 months ago

snickerdoodleparent commented 3 months ago

corrected header to Authentication and changed line 20 to line 28. (it was line 28 for my browser build)

MikePlante1 commented 3 months ago

Thanks! I checked the code and see you're correct.

MikePlante1 commented 3 months ago

In testing this, I also noticed that it should be updated to say

if false && context.canEvaluatePolicy(.deviceOwnerAuthentication, error: &error) {

instead of

if false, context.canEvaluatePolicy(.deviceOwnerAuthentication, error: &error) {

Both work, but the second saves Xcode from doing an auto-correct for formatting.

If you want to update that in this PR, that'd be great... but if you'd rather not that's okay too and I can just submit a new PR for that after this one is accepted and merged.

snickerdoodleparent commented 3 months ago

Thanks for noticing that, I'll update it, then it'll be done in one.

MikePlante1 commented 3 months ago

Thanks for noticing that, I'll update it, then it'll be done in one.

Awesome, thank you!

MikePlante1 commented 3 months ago

Merging with 2 approvals