nightscout / trio-oref

MIT License
7 stars 4 forks source link

Fixed an issue with SMB logic. #19

Closed JeremyStorring closed 5 months ago

mountrcg commented 5 months ago

@JeremyStorring I proposed in #20 a fix to be done in iAPS. The second part of this PR would still make sense and re-ensure the part where I suggested that in OiAPS if someone toggles smbIsOff to true then smbIs AlwaysOff should be set to false.

mountrcg commented 5 months ago

The second part of this PR would still make sense

but of course vice-versa as I think the variable naming is "off" in OiAPS not in oiref.

bjornoleh commented 5 months ago

Closing this in favour of https://github.com/nightscout/open-iaps-oref/pull/20, which has already been merged.