Filtering issue for newly added disease

[partnersmap]

Gastrointestinal Illness was recently added as a disease. When you use the filter bar the numbers are correct when looking at projects under that disease globally.

but when you click on a country, it reports all project in the country and the filter is lost.

[dtpowl]

@partnersmap This one was tricky but it should be working now.

[partnersmap]

Looks like there is still a bug when going to the 2nd administrative level. It looks like it is only an issue for the Dominican Republic. Is this something on my end? Within the data entry process?

After clicking on one of the "4's" it only gives one project.

[partnersmap]

When looking at all World Water Relief projects in the Dominican Republic (these are the ones with the new disease - Gastrointestinal Illness), the numbers also don't match up. It reports 10 projects total when there are really 12. This bug might be related.

[dtpowl]

@partnersmap Yeah, it's possible that these are related. It's probably a problem on my end and not yours. Looking into it now.

[dtpowl]

I made a fairly large set of changes for this, so the fix is in PR #140.

[dtpowl]

@partnersmap Try this one out now.

[partnersmap]

It looks like both pin issues are still present

[dtpowl]

@partnersmap Oh, I'm sorry! We merged the changes but I don't think we deployed.

[dtpowl]

@partnersmap I apologize for that. Changes are live now.

[partnersmap]

No worries! It looks like things are still fishy with the Dominican Republic pathway.

Using the Disease->Gatrointestinal illness->Dominican Republic route, after clicking on one of the "4" it brings you to one project. For the three "4s", the only projects that show up at the 2nd administrative level are "WASH in Schools - Batey Los Robles" "Community Clinic Clean Water System - Batey 7" and "WASH in Schools - Batey 6"

Using the Organization->World Water Relief->Dominican Republic route, shows the "We're Sorry, there is an error and the page couldn't be loaded." screen.

[dtpowl]

Okay, the "We're Sorry" page should be fixed. Working on the pin counts now.

[dtpowl]

Hmm. Actually, the Dominican Republic looks right to me.

I tried clicking each of the three regions, and each one took me to a list of four projects in that region, as expected.

Can you try clearing your browser cache and retrying?

[partnersmap]

Okay, yeah. I tried it in another browser and it looks good!

It looks like there is still something with the 12 projects represented as only 10 (the last picture above). This isn't a crucial fix, because the pathways still work but I didn't know if you saw the bug for it when fixing the other issues.

[dtpowl]

Cool!

Will work on the 12/10 problem next.

[dtpowl]

@partnersmap Speaking of this, do we actually want the country pin to appear on the map at the regional level? I know we talked about this in another issue but I'm not sure if we ever settled on a solution.

This might be a good opportunity to fix this, if you want to prevent that from happening. In fact, it seems like it's happening for the organization filter but not for all of the others; seems like it ought to be consistent at least.

[partnersmap]

If we did get rid of the country pin at the regional level, would projects that are only at the country level have an indicator? Say for example, Dominican has 12 projects in it and 2 of them are at the country level (the rest are regional/district). When you click on the Dominican, we would ideally want the 2 that are country level to still show up. So, indicators with: 4 projects in region x, 3 in region y, 3 in region z, and 2 in Dominican. I think that would be ideal. Would it be a pain? I think we initially held on this because it is a cosmetic fix.

[dtpowl]

I don't think it will be too hard, but it's a little hard to predict because the existing behavior is definitely buggy. But if I can't manage to wrap it up today I'm sure I can have it done early next week.

[partnersmap]

Sounds good to me. If it is too buggy we can always abort this one. I'm not sure if the users would catch it, but it would be nice.

[dtpowl]

I'll give it a shot and if any huge complications crop up, I'll give you a heads-up and we can re-evaluate. I think it'll be fine, though.

[dtpowl]

@partnersmap The country-level pins should be working now.