nightstyles / alembic

Automatically exported from code.google.com/p/alembic
Other
1 stars 0 forks source link

getFullName() for Objects should not report implementation-specific names #128

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Right now, there are some "magic" names of some of the elements in the HDF5 
path.  For example, "/ABC" for the top Object, or ".prop" for an Object's 
CompoundProperty.  Since these names are defined in the CoreHDF5 layer and 
their labeled entities are never referred to by name in the public layers, it's 
inappropriate to expose them to the user via the CoreAbstract or Abc layer 
with, eg, "getFullName()".

I've updated Abc::IObject::getFullName() to strip "ABC" from the beginning of 
the name, but this really should be done at the HDF5 layer (BaseOrImpl.h).  A 
similar treatment needs to be done for ".prop".

Original issue reported on code.google.com by ard...@gmail.com on 23 Dec 2010 at 8:31

GoogleCodeExporter commented 9 years ago
This is now done for ObjectHeader::getFullName() (and therefore anything that 
uses that, like AbcA::ObjectReader::getFullName(), Abc::IObject::getFullName()):

http://code.google.com/r/ardent-embic/source/detail?r=2849c83f56abf0fe800c17bb9d
f9c8cbbc097149

If you get the Top Object and call "getName()", you'll still get back "ABC".  I 
think this is OK, because if are looking specifically at the Top Object, you'll 
want its real name.  But its full name is just "/".

Original comment by ard...@gmail.com on 18 Jan 2011 at 11:38

GoogleCodeExporter commented 9 years ago

Original comment by ard...@gmail.com on 19 Jan 2011 at 9:30

GoogleCodeExporter commented 9 years ago

Original comment by ard...@gmail.com on 15 Feb 2011 at 3:56