search

nightvisi0n / dockgraph

Analyse dependencies of docker images.
Creative Commons Attribution Share Alike 4.0 International
2 stars 1 forks source link

Remove try/except from import of argcomplete #31

Open nightvisi0n opened 8 years ago

nightvisi0n commented 8 years ago

I don't think it is needed to try to import argcomplete since we already specified in requirements.txt that we depend on it? This would also fix our last coding style issue on quantifiedcode and would improve our code coverage :wink:

nightvisi0n commented 8 years ago

@sedrubal what do you think about this?

sedrubal commented 8 years ago

That's right, but I think it's cool to run the script directly with ./dockgraph_py.cli. Argcomplete is only to make it nicer to use but if it is not installed, features shouldn't break. And I think it's not much effort to wrap in in a try catch... But we can remove it anyway...

nightvisi0n commented 8 years ago

That's right, but I think it's cool to run the script directly with ./dockgraph_py.cli.

I don't get why this wouldn't be possible without the try/except statement..

My intention with this issue was also to improve the user experience of the cli. Personally i find it very frustrating when a cli doesn't support argument completion (out of the box!). Thus i would propose argcomplete as a requirement in terms of user experience. :wink:

sedrubal commented 8 years ago

That's right, but I think it's cool to run the script directly with ./dockgraph_py.cli.

I don't get why this wouldn't be possible without the try/except statement..

I meant without installing requirements.

My intention with this issue was also to improve the user experience of the cli. Personally i find it very frustrating when a cli doesn't support argument completion (out of the box!). Thus i would propose argcomplete as a requirement in terms of user experience. :wink:

OK.